Corrected Signal.hammingWindow implementation. #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnal.hammingWindow_old
nhthn
reviewed
Feb 23, 2019
|
Just did, hopefully you've received the notification. |
|
thanks, will push. no need to send invite, just make sure the "Allow edit from maintainers" checkbox to the right of this PR is checked. i'm asking as a formality since i don't want to accidentally push while you're working on the branch! |
|
ack, github isn't letting me push. could you merge this PR then? khoin#1 |
* help: Document Signal.hammingWindow_old * sclang: Add unit tests for four Signal methods
|
I merged it to khoin/develop |
nhthn
approved these changes
Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected Signal.hammingWindow implementation.
Old method moved to Signal.hammingWindow_old.
See #4323