Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main menu: don't init menu actions in initClass; document #4285

Merged
merged 1 commit into from
Feb 3, 2019
Merged

main menu: don't init menu actions in initClass; document #4285

merged 1 commit into from
Feb 3, 2019

Conversation

mossheim
Copy link
Contributor

@mossheim mossheim commented Feb 3, 2019

Purpose and Motivation

changes to MainMenu for 3.10.2

make behavior opt-in only, leave a warning note in the documentation.
add some documentation.

Types of changes

  • Documentation (non-code change which corrects or adds documentation for existing features)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • All tests are passing
  • If necessary, new tests were created to address changes in PR, and tests are passing
  • Updated documentation, if necessary
  • This PR is ready for review

@mossheim mossheim requested review from scztt and nhthn February 3, 2019 00:01
@mossheim mossheim added comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" comp: Qt GUI sclang Qt components -- for IDE tickets, use "env: SCIDE" instead comp: help schelp documentation labels Feb 3, 2019
@mossheim mossheim added this to the 3.10.2 milestone Feb 3, 2019
nhthn
nhthn reviewed Feb 3, 2019
View reviewed changes
SCClassLibrary/Common/GUI/Base/Menu.sc Outdated
*initClass {
*initClass {}

*initControlMenuActions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this name is technically accurate but feels a little awkward to me -- maybe initBuiltInMenus instead?

@mossheim
Copy link
Contributor Author

mossheim commented Feb 3, 2019

@snappizz updated

@nhthn nhthn merged commit e70187a into supercollider:3.10 Feb 3, 2019
@mossheim mossheim deleted the topic/main-menu-fixup branch February 3, 2019 22:27
@nhthn nhthn mentioned this pull request Feb 4, 2019
Closed
@jrsurge jrsurge mentioned this pull request Sep 11, 2019
Closed
@mossheim mossheim restored the topic/main-menu-fixup branch April 10, 2020 18:53
@mossheim mossheim deleted the topic/main-menu-fixup branch August 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhthn nhthn nhthn approved these changes

@scztt scztt Awaiting requested review from scztt

Assignees
No one assigned
Labels
comp: help schelp documentation comp: Qt GUI sclang Qt components -- for IDE tickets, use "env: SCIDE" instead comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library"
Projects
None yet
Milestone
3.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mossheim @nhthn