scide: Fix missing icon #4269
Merged
scide: Fix missing icon #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossheim
reviewed
Jan 24, 2019
nhthn
force-pushed
the
topic/scide-icon
branch
from
a948f3c to
42b6b72
Compare
nhthn
force-pushed
the
topic/scide-icon
branch
from
42b6b72 to
ce77dce
Compare
mossheim
reviewed
Jan 24, 2019
|
On Ubuntu 18.04, the SCIDE icon shows up again in the "About SuperCollider" window. I haven't noticed any other changes.
|
patrickdupuis
approved these changes
Jan 25, 2019
Closed
|
The missing icon is still an issue for me. I'm running KDE on Kubuntu 20.04 and built the latest 12.1 SuperCollider from source. |
|
the best is you reopen #3905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
fixes #3905 -- SCIDE is missing an icon. turns out it was something silly, the
QIconpath should be:icons/blahrather than:/icons/blah.unfortunately we can't use the svg icon because of #2646 (icon appears tiny on some linux DEs), so i just used the PNGs.
Types of changes
Checklist