Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/tempo clock is running #4254

Merged
merged 5 commits into from
Jan 20, 2019

Conversation

jamshark70
Copy link
Contributor

@jamshark70 jamshark70 commented Jan 15, 2019

Purpose and Motivation

It's kind of a no-brainer to be able to ask a TempoClock if it's still running -- it might have been stopped, but in the main class library as it is now, you have no way to know, except to try to schedule something on it and catch an error (!).

So I propose a very simple isRunning method. Actually, I've had this in my extensions for years. It works.

Plus documentation.

Plus a unit test... but then I thought, there are some other things about TempoClock (correct rate of advancing through time, handling of meter changes) that are probably not tested anywhere else. So I added a bunch of other useful tests.

Types of changes

  • Documentation (non-code change which corrects or adds documentation for existing features)
  • New feature (non-breaking change which adds functionality)

Checklist

  • All previous tests are passing (well, I did try to run the entire test suite, but TestUGen_Duty locked up the system and forced me to hard reboot... so to be completely honest, I don't know, but I don't think that's the fault of this PR)
  • Tests were updated or created to address changes in this PR, and tests are passing
  • Updated documentation, if necessary
  • This PR is ready for review

Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

SCClassLibrary/Common/Core/Clock.sc Outdated Show resolved Hide resolved
testsuite/classlibrary/TestTempoClock.sc Outdated Show resolved Hide resolved
testsuite/classlibrary/TestTempoClock.sc Outdated Show resolved Hide resolved
testsuite/classlibrary/TestTempoClock.sc Outdated Show resolved Hide resolved
testsuite/classlibrary/TestTempoClock.sc Outdated Show resolved Hide resolved
testsuite/classlibrary/TestTempoClock.sc Outdated Show resolved Hide resolved
testsuite/classlibrary/TestTempoClock.sc Show resolved Hide resolved
@mossheim mossheim added this to the 3.10.2 milestone Jan 17, 2019
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass, thanks!

@mossheim
Copy link
Contributor

Please wait until after 3.10.1 to merge

@mossheim mossheim merged commit 9a651bf into supercollider:3.10 Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants