-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/tempo clock is running #4254
Merged
mossheim
merged 5 commits into
supercollider:3.10
from
jamshark70:topic/TempoClockIsRunning
Jan 20, 2019
Merged
Topic/tempo clock is running #4254
mossheim
merged 5 commits into
supercollider:3.10
from
jamshark70:topic/TempoClockIsRunning
Jan 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossheim
suggested changes
Jan 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
mossheim
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests pass, thanks!
Please wait until after 3.10.1 to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
It's kind of a no-brainer to be able to ask a TempoClock if it's still running -- it might have been stopped, but in the main class library as it is now, you have no way to know, except to try to schedule something on it and catch an error (!).
So I propose a very simple
isRunning
method. Actually, I've had this in my extensions for years. It works.Plus documentation.
Plus a unit test... but then I thought, there are some other things about TempoClock (correct rate of advancing through time, handling of meter changes) that are probably not tested anywhere else. So I added a bunch of other useful tests.
Types of changes
Checklist