Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: Fix CheckBadValues for zeros on MSVC #4240

Merged
merged 1 commit into from
Jan 11, 2019
Merged

plugins: Fix CheckBadValues for zeros on MSVC #4240

merged 1 commit into from
Jan 11, 2019

Conversation

nhthn
Copy link
Contributor

@nhthn nhthn commented Jan 9, 2019

fix #4238. this can't really be unit tested because the bug was only in post window printing, so here's a test case:

{ CheckBadValues.ar(LFPulse.ar(10)); DC.ar(0) }.play; // this shouldn't post anything
{ CheckBadValues.ar(1 / LFPulse.ar(10)); DC.ar(0) }.play; // this should

plugins: Fix CheckBadValues for zeros on MSVC
4977571 
This commit fixes a bug in the CheckBadValues ugen affecting MSVC. Preprocessor directives were in this code as a workaround for MSVC std::fpclassify not supporting FP_ZERO. This is no longer the case.

For supercollider#4238.
@nhthn nhthn added this to the 3.10.1 milestone Jan 9, 2019
mossheim
mossheim approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@nhthn
Copy link
Contributor Author

nhthn commented Jan 9, 2019

just tested on windows and linux, seems to work.

@patrickdupuis patrickdupuis merged commit 2467921 into supercollider:3.10 Jan 11, 2019
@nhthn nhthn mentioned this pull request Jan 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
comp: server plugins
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nhthn @mossheim @patrickdupuis