sclang: fix resolveIfAlias [skip appveyor] #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an infinite hang in SC_Filesystem::resolveIfAlias on certain input files (unknown cause). also add regression test, update message in TestSerialPort fixes #4131
mossheim
added
comp: sclang
|
Can someone please review this so we can move toward creating an RC for 3.10.1? I have already noted the things I tested above. |
patrickdupuis
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
fixes an infinite hang in SC_Filesystem::resolveIfAlias on certain input
files (unknown cause).
also add regression test, update message in TestSerialPort
fixes #4131
Types of changes
Checklist
Notes on testing
This affects all places
standardizePathis used, and class librarycompilation. I don't know for certain whether the old behavior is
maintained under all cases. Here are the cases that do stay the same:
I'm not enough of a macOS filesystem expert to know if there are corner
cases this misses. It's really unfortunate that this code now has to do a full
string compare when we previously had a bool; if anyone can find a
better way please let me know!
If this goes into 3.10.1 (which i would expect it to) I would say this
change alone warrants a beta release so any obvious failings can be
caught.