Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scide: fix hex int highlighting #4170

Merged
merged 1 commit into from
Nov 25, 2018
Merged

scide: fix hex int highlighting #4170

merged 1 commit into from
Nov 25, 2018

Conversation

mossheim
Copy link
Contributor

Purpose and Motivation

hex numbers starting with 0X are actually not allowed, so don't highlight them

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • All tests are passing
  • If necessary, new tests were created to address changes in PR, and tests are passing
  • Updated documentation, if necessary
  • This PR is ready for review

@mossheim
scide: fix hex int highlighting
6aa6d98 
hex numbers starting with 0X are actually not allowed, so don't highlight them
@mossheim
Copy link
Contributor Author

relevant lexer line:

https://github.com/supercollider/supercollider/blob/develop/lang/LangSource/PyrLexer.cpp#L652

@nhthn nhthn added this to the 3.10.1 milestone Nov 25, 2018
nhthn
nhthn approved these changes Nov 25, 2018
View reviewed changes
Copy link
Contributor

@nhthn nhthn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine, thanks!

@patrickdupuis patrickdupuis merged commit b3f9c5e into supercollider:3.10 Nov 25, 2018
@mossheim mossheim deleted the topic/less-hex branch November 25, 2018 21:12
@mossheim mossheim restored the topic/less-hex branch April 10, 2020 18:52
@mossheim mossheim deleted the topic/less-hex branch August 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhthn nhthn nhthn approved these changes

Assignees
No one assigned
Labels
env: SCIDE
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mossheim @nhthn @patrickdupuis