-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/unit test info #4028
Topic/unit test info #4028
Conversation
.github/PULL_REQUEST_TEMPLATE.md
Outdated
- [ ] Updated documentation, if necessary | ||
- [ ] This PR is ready for review | ||
|
||
<!--- See DEVELOPING.md for instructions on running and writing tests. --> | ||
<!--- See DEVELOPING.md and https://github.com/supercollider/supercollider/wiki/Unit-Testing-Guide for instructions on running and writing tests. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, must disagree with putting a URL here. this template is already too long, and you have to copy-paste the link.
I’m not sure why Travis should have failed... |
Looks like unit tests |
@muellmusik you have the ability to restart CI builds - login to Travis and AppVeyor with your github credentials (choose "SuperCollider" account in AppVeyor) |
@brianlheim done in travis; can't see where to restart in AppVeyor. I was more wondering why a commit to an md file should cause builds to fail |
Simple version of the answer - because our CI script sometimes fails for no good reason. Something to do with buffering. Re AppVeyor if you follow the link from the failing build here and are signed into the supercollider acct you will see a "rebuild commit" button. Easy way to check kf you're signed into the right acct is by going to Projects and you should see sc and sc3 plugins as the projects available. |
I can see those, but can't see the rebuild button. Anyway, it's irrelevant for this PR, oder? |
@brianlheim I tried again on my phone. Can see the projects, but not the rebuild button. It also says I can log in as you, which doesn’t seem right. |
This is still failing on the Qt5.9 App Store build, but none of the changes touches compilable code, so I think it’s irrelevant. Is it possible to finish review and merge? |
Yes, it's fine, the failure is just due to an old version of the appveyor script on your feature branch. Sorry that that noise was all over this PR. Also wanted to note that Core Team group members are definitely now able to restart AppVeyor builds; I had missed a checkbox within Appveyor's web UI. :) Thanks for your patience everyone! |
Purpose and Motivation
Add info on test expectations and links to info on unit test best practice
Types of changes
Checklist