Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Correct the 'pvcollect' example function #4016

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

jamshark70
Copy link
Contributor

Purpose and Motivation

b4b70b4 introduces a copy/paste error into the documentation for pvcollect.

The function for this method should take the magnitude and phase for a single bin, and return either a new magnitude or a magnitude/phase pair for this bin only.

The revision adds an "example function" that takes | magnitude, phase, bin, index | as arguments but then returns [mags.reverse, phases.reverse]. mags and phases are undeclared, so this will never work. Also, it's conceptually inconsistent. pvcollect operate on individual bins, not on all of them at once: reverse doesn't make sense in this context. But it does make sense for pvcalc.

The PR replaces the return with a simple per-bin randomizer.

Types of changes

  • Documentation

Checklist

  • [n/a] All tests are passing
  • [n/a] If necessary, new tests were created to address changes in PR, and tests are passing
  • Updated documentation, if necessary
  • This PR is ready for review

(It's a correction for a typo. The checklist is basically superfluous.)

@jamshark70 jamshark70 added the comp: help schelp documentation label Aug 25, 2018
@mossheim mossheim merged commit 747f502 into supercollider:develop Aug 26, 2018
@nhthn nhthn mentioned this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: help schelp documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants