Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: set minimum version to 3.5 #3656

Merged
merged 3 commits into from
May 29, 2018
Merged

cmake: set minimum version to 3.5 #3656

merged 3 commits into from
May 29, 2018

Conversation

mossheim
Copy link
Contributor

@mossheim mossheim commented Apr 9, 2018 •
edited
Loading

@mossheim mossheim added the comp: build CMake build system label Apr 9, 2018
nhthn
nhthn previously approved these changes Apr 9, 2018
View reviewed changes
@mossheim mossheim added this to the 3.10 milestone Apr 9, 2018
@mossheim
Copy link
Contributor Author

mossheim commented Apr 9, 2018

please review again - I realized I hid the option definition on macOS & Windows, so refactored the check and used a variable to make it a little cleaner. I confirmed locally that this has the correct behavior.

@mossheim mossheim dismissed nhthn’s stale review May 26, 2018 20:41

Still needs another review

nhthn
nhthn approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@nhthn nhthn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nhthn nhthn merged commit 36e9114 into supercollider:develop May 29, 2018
@mossheim mossheim deleted the topic/cmake-update branch May 29, 2018 07:07
@mossheim mossheim mentioned this pull request May 29, 2018
Merged
@mossheim mossheim restored the topic/cmake-update branch April 10, 2020 18:50
@mossheim mossheim deleted the topic/cmake-update branch August 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhthn nhthn nhthn approved these changes

Assignees
No one assigned
Labels
comp: build CMake build system
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.
2 participants
@mossheim @nhthn