classlib: fix String methods that use path separators #3634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically,
+/+
,withTrailingSlash
,withoutTrailingSlash
This is a fix for a bug reported on the mailing list (link forthcoming). Basically, the way we were testing for path separators wasn't very portable or robust.
Also adds tests and documentation.
Shoutout to @aspiers - I was using guard for this and it made the whole process so much smoother!