Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Warp1 UGen example and some code cosmetics #3526

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Improve Warp1 UGen example and some code cosmetics #3526

merged 2 commits into from
Feb 20, 2018

Conversation

telephon
Copy link
Member

No description provided.

@telephon
help: improve Warp1 example
5b8178a 
This strips away some boilerplate code and concentrates on the ugen
itself. Also keeping it running makes it easier to experiment with.
@telephon
class library: GrainUGens - code cosmetics
b7675b6
joshpar
joshpar approved these changes Feb 18, 2018
View reviewed changes
Copy link
Member

@joshpar joshpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all fine with me.

joshpar
joshpar reviewed Feb 18, 2018
View reviewed changes
Copy link
Member

@joshpar joshpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we moving away from SynthDef in examples? I'm fine if we are, that would be my only concern here.

@telephon
Copy link
Member Author

I find SynthDefs often a bit distracting from the main point. But I wouldn't try to remove them everywhere!

patrickdupuis
patrickdupuis approved these changes Feb 19, 2018
View reviewed changes
Copy link
Contributor

@patrickdupuis patrickdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave the class file changes a good look over. Ideally, these fixes would have been done in 2 seperate PRs for easier review.

@patrickdupuis patrickdupuis added this to the 3.9.2 milestone Feb 19, 2018
@telephon telephon merged commit 691c179 into supercollider:develop Feb 20, 2018
miguel-negrao pushed a commit to miguel-negrao/supercollider that referenced this pull request Mar 2, 2018
@telephon @miguel-negrao
Merge pull request supercollider#3526 from telephon/topic-warp1-example
0fe7b33 
Improve Warp1 UGen example and some code cosmetics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpar joshpar joshpar approved these changes

@patrickdupuis patrickdupuis patrickdupuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@telephon @joshpar @patrickdupuis