Fix PSinGrain #3494
Merged
Fix PSinGrain #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a missing update of the member variable in the plugin code.
This is mainly for ear protection. Existing uses may fall quiet. But those must have been hacks around the broken current behaviour anyway.
|
First time trying @brianlheim's wonderful cherry-picking script. Did I get it right? |
|
@patrickdupuis nice! You should try the new version of the script; it will reference the original (so the link will appear in the other PR's conversation) and also includes a link to the script itself. https://gist.github.com/brianlheim/7809f7a062362f0ea3ff1490ae12694b |
|
Sweet!
…________________________________
From: Brian Heim <notifications@github.com>
Sent: February 4, 2018 6:27 PM
To: supercollider/supercollider
Cc: Patrick Dupuis; Mention
Subject: Re: [supercollider/supercollider] Cherry-picking #3493 onto 3.9 (#3494)
@patrickdupuis<https://github.com/patrickdupuis> nice! You should try the new version of the script; it will reference the original (so the link will appear in the other PR's conversation) and also includes a link to the script itself.
https://gist.github.com/brianlheim/7809f7a062362f0ea3ff1490ae12694b
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#3494 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALNCHr3E_0DvMftuzwyKbjbTzk0JOottks5tRjzdgaJpZM4R4wWn>.
|
telephon
approved these changes
Feb 5, 2018
Closed
|
This works, awesome! |
mossheim
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.