Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic fix psingrain #3493

Closed
wants to merge 2 commits into from
Closed

Topic fix psingrain #3493

wants to merge 2 commits into from

Conversation

telephon
Copy link
Member

@telephon telephon commented Feb 4, 2018

Fixes #3372.

@telephon
plugins: PSinGrain now counts down correctly
dc83c69 
This patch adds a missing update of the member variable in the plugin
code.
@telephon
plugins: standardise PSinGrain default amplitude
c668c1a 
This is mainly for ear protection. Existing uses may fall quiet. But
those must have been hacks around the broken current behaviour anyway.
@mossheim mossheim added this to the 3.9.2 milestone Feb 4, 2018
@telephon telephon changed the base branch from develop to 3.9 February 4, 2018 21:45
@telephon telephon changed the base branch from 3.9 to develop February 4, 2018 21:45
@telephon
Copy link
Member Author

telephon commented Feb 4, 2018

needs cherry-picking …

@mossheim
Copy link
Contributor

mossheim commented Feb 4, 2018

you could rebase locally and force push if you're in a brave mood :)

git rebase 3.9 topic-fix-psingrain
git checkout topic-fix-psingrain
git push -f origin

@patrickdupuis patrickdupuis mentioned this pull request Feb 4, 2018
Merged
@telephon
Copy link
Member Author

telephon commented Feb 6, 2018

Superseded by #3494

@telephon telephon closed this Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp: server plugins
Projects
None yet
Milestone
3.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@telephon @mossheim