Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: improve errors thrown by Windows installer target #3464

Merged
merged 3 commits into from
Jan 25, 2018
Merged

cmake: improve errors thrown by Windows installer target #3464

merged 3 commits into from
Jan 25, 2018

Conversation

mossheim
Copy link
Contributor

@mossheim mossheim commented Jan 23, 2018 •
edited
Loading

  • If NSIS is not found, throw a fatal error
  • If installer command fails, throw a fatal error

Fixes #3443, fixes #3444

I tested this under several conditions:

  • NSIS out of path
  • installer requested without install target built
  • installer requested but necessary package contents missing
  • installer requested with install target built

In all cases, this produced the correct result (only the last one succeeded, the rest were regarded as errors).

@mossheim mossheim added comp: build CMake build system os: Windows labels Jan 23, 2018
@mossheim mossheim added this to the 3.9.1 milestone Jan 23, 2018
nhthn
nhthn approved these changes Jan 25, 2018
View reviewed changes
Copy link
Contributor

@nhthn nhthn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust you know what you're doing

@patrickdupuis patrickdupuis merged commit c4900e9 into supercollider:3.9 Jan 25, 2018
@mossheim mossheim deleted the issue/3443 branch January 25, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhthn nhthn nhthn approved these changes

Assignees
No one assigned
Labels
comp: build CMake build system os: Windows
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mossheim @nhthn @patrickdupuis @brian235711