Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classlib: fix for leaking routine in plotTree #3423

Merged
merged 1 commit into from
Jan 16, 2018
Merged

classlib: fix for leaking routine in plotTree #3423

merged 1 commit into from
Jan 16, 2018

Conversation

redFrik
Copy link
Contributor

@redFrik redFrik commented Jan 14, 2018

fix for a minor problem that happens when pressing cmd+period while a plotTree window is open.

s.boot
s.dumpOSC  //to debug

s.plotTree
//now close the window - OK - g_queryTree messages are no longer being posted

s.plotTree
CmdPeriod.run  //or typing cmd+.
//again close the window - BAD - leaking routine - g_queryTree still being posted

with the suggested change the second example work as expected and the internal updater routine is stopped.

@nhthn nhthn added this to the 3.9.1 milestone Jan 14, 2018
@mossheim mossheim changed the base branch from develop to 3.9 January 16, 2018 02:28
@mossheim mossheim merged commit ab5b268 into supercollider:3.9 Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telephon telephon telephon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@redFrik @telephon @nhthn @mossheim