scide: adding solarizedLight and solarizedDark themes #3412
Conversation
|
@redFrik we should also add both solarized ones as well :) |
|
I would support adding both :) |
|
i should've mentioned that this is after https://github.com/helmholtz/sc-solarized |
|
Same as with #3410, just want to make sure that licensing has been properly considered. |
|
As was discussed on slack, adding this and other themes via separate C++ files requires a little more work than expected. It was decided to simply add the license text above the function that contains the theme's colour palette. I've created a PR against @redFrik's branch which adds the license text. |
|
Ping @redFrik. We'd like to get this into 3.9.1 if possible. |
|
thanks for taking care of adding the licence. i'm happy to see this go into 3.9.1. is there something i need to do though? like some button click on github? |
|
First, you need to merge redFrik#2 so that those changes become part of this PR. There may be some sort of conflict that needs to be resolved before this can be merged into |
|
ok @patrickdupuis merged and resolved. hope it's good now. thanks for your help |
|
@snappizz Good to go? |
| @@ -271,6 +355,11 @@ Theme::Theme(const QString & _name, Manager * settings) | |||
| mLocked = true; | |||
| } else if (mName == "dracula") { | |||
| fillDracula(); | |||
| } else if (mName == "solarizedLight") { | |||
There was a problem hiding this comment.
There needs to be a line mLocked = true in the block above.
sorry, must have happened when i resolved conflicts
mossheim
dismissed
nhthn’s stale review
Licensing issues have been addressed.
i add it here but we can close directly if the dracula theme is preferred. #3410