-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scide - theme: add dracula #3410
Conversation
Signed-off-by: Yvan Volochine <yvan.github@gmail.com>
wow, it looks very nice! @gusano are you sure using this theme doesn't require a license or attribution of some sort? |
@brianlheim that's very much possible https://github.com/dracula/dracula-theme/blob/master/LICENSE |
@gusano OK. Neither am I. I think it would be best to get in contact with them and ask how/if we should include the license text. |
Trying this out. @gusano can you confirm the colour of the following text in the Post Window?
In your screenshots, it appears in white-ish. For me, it appears in black. |
the MIT license is GPL-compatible, we are fine in copyrightland |
For sure MIT is fine, but how do we properly credit the authors? Do we need to include a license file somewhere? |
@patrickdupuis yes it is white here (no custom theme in About the license, I'd rather have themes as |
Looks nice. I'm sceptic that copyright applies to the use of a range of RGB values. http://www.colourlovers.com/faq/18/How_can_you_copyright_a_color_palette is quite vague about it, claiming that you could protect "the arrangement of those colors into the rectangular shape" only. |
OK, yet the repository has a license, and we're copying the name here. I think it would be best to contact them just as a gesture of good faith. |
(they may also want to know purely for the sake of adding it to their list of projects using it) |
@gusano - I'm not sure what you mean by this. Would you still want this to be reviewed/merged as-is or should it be closed and an issue opened for yaml-format themes? |
@brianlheim I already opened an issue for supporting yaml themes and I think it might take some time to be done.. Reviewing/merging this one is up to you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would recommend adding the Theme::fillDracula()
function to a separate C++ file with a comment on top indicating the full license.
As was discussed on slack, adding this and other themes via separate C++ files requires a little more work than expected. It was decided to simply add the license text above the function that contains the theme's colour palette. |
Some screenshots: