Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scide: set default font backup to Monaco #3404

Merged
merged 1 commit into from
Jan 16, 2018
Merged

scide: set default font backup to Monaco #3404

merged 1 commit into from
Jan 16, 2018

Conversation

mossheim
Copy link
Contributor

This fixes issue #2389 by adding a backup for the default IDE font. It
keeps the "monospace" family that currently works for Linux & Windows.
Monaco is the default font for macOS's terminal, so it's safe to assume
this will be installed for almost all users.

@mossheim
Copy link
Contributor Author

mossheim commented Jan 11, 2018 •
edited
Loading

I've tested this and it works as expected on macOS (10.13.2). The font substitutions are tried in-order, which means that for any other platform that made use of monospace (Linux and Windows), this has no effect.

@mossheim mossheim added this to the 3.9.1 milestone Jan 11, 2018
@mossheim mossheim mentioned this pull request Jan 11, 2018
Closed
@nhthn nhthn changed the base branch from develop to 3.9 January 14, 2018 18:49
@nhthn nhthn changed the base branch from 3.9 to develop January 14, 2018 18:49
@patrickdupuis
Copy link
Contributor

Shouldn't this be merged into 3.9? It will get into develop the next time 3.9 is merged into develop (in a week or so?).

@mossheim mossheim changed the base branch from develop to 3.9 January 16, 2018 02:26
@mossheim mossheim changed the base branch from 3.9 to develop January 16, 2018 02:26
@mossheim
scide: set default font backup to Monaco
1e39cbc 
This fixes issue #2389 by adding a backup for the default IDE font. It
keeps the "monospace" family that currently works for Linux & Windows.
Monaco is the default font for macOS's terminal, so it's safe to assume
this will be installed for almost all users.
@mossheim mossheim changed the base branch from develop to 3.9 January 16, 2018 02:28
@mossheim
Copy link
Contributor Author

@patrickdupuis It was based on develop originally. I just rebased and force-pushed, should be OK to go after CI finishes

@patrickdupuis patrickdupuis merged commit 8567e7e into supercollider:3.9 Jan 16, 2018
@mossheim mossheim deleted the issue/2389 branch January 16, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telephon telephon telephon approved these changes

Assignees
No one assigned
Labels
env: SCIDE os: macOS
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mossheim @patrickdupuis @telephon