plugins: deprecate PSinGrain #3372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates PSinGrain for 3.10.
|
ping |
patrickdupuis
approved these changes
Jan 6, 2018
|
I'm not totally convinced it makes sense to deprecate this – I think it's reasonable to keep it around as long as it's documented as a FIXME. Unlike some of the other UGens, PSinGrain is only about 100 LOC, so I think it wouldn't be too hard to fix if someone wanted to invest time into it. |
|
Having spent some time thinking about it - if this isn't deprecated it seems like there's a very low chance anyone will come along and fix it. I am ok with this now. @telephon - what do you think? |
|
I think it's worth fixing. |
|
I've just fixed it in one line. Into what branch should it go? |
Closed
Oh, wonderful! This can go into 3.9.2. Closing this PR since it's no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSinGrain is a fast way of generating a sine wave grain with a parabolic envelope. it performs its intended purpose, but after the grain finishes, it starts increasing in amplitude again and never stops, which is pretty useless. it might be salvageable, but it's not worth the trouble in my view. this commit deprecates it.
closes #3292.