SCIDE: Separate server actions into Server menu #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossheim
reviewed
Jul 17, 2017
|
|
||
| menuBar->addMenu(menu); | ||
|
|
||
| menu = new QMenu(tr("Se&rver"), this); |
There was a problem hiding this comment.
Shouldn't this be "&Server"?
There was a problem hiding this comment.
S is already the shortcut for the Session menu, so I had to pick something else.
mossheim
approved these changes
Jul 17, 2017
|
Tested and works on macOS |
|
I guess I should mentioned I developed / tested this on macOS as well. Needs some testing on Linux and Windows. I don't have the dev environment set up on either just yet. |
|
np. I get the impression that Qt stuff is usually good cross-platform, but I don't know a lot about it so I'm being cautious. I'm about to build this on Windows actually. |
|
works on windows! |
|
Looks good on Linux over here 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2852