Refactor Function plot and loadToFloatArray #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to load a function into an array, too. Also the code is cleaned up now.
After this refactoring, you can now just get a buffer from a function directly.
Just a convenience, but will prove very useful.
mossheim
suggested changes
Jul 18, 2017
HelpSource/Classes/Function.schelp
Outdated
| @@ -448,6 +448,32 @@ argument:: separately | |||
| For multi channel signals, set whether to use separate value display ranges or not. | |||
| a window to place the plot in. If nil, one will be created for you. | |||
|
|
|||
|
|
|||
| method::asBuffer | |||
| Calculates duration in seconds worth of the output of this function, and returns it in a link::Classes/Buffer:: of the number of channels. This method immediately returns a buffer, which takes code::duration:: seconds to become filled with data. Then the action function is called. | |||
There was a problem hiding this comment.
probably better to say "which is filled asynchronously" - it may take slightly longer than the duration of the buffer for the data to move around.
HelpSource/Classes/Function.schelp
Outdated
| A function that is called when the buffer is filled. It is passed the buffer as argument. | ||
|
|
||
| argument::fadeTime | ||
| A fade in and out time in seconds. (Only) when given, an envelope is applied to the signal to avoid clicks. |
There was a problem hiding this comment.
Wondering about the functionality of this... what if we make the default value 0, and then check if fadeTime is == 0? IIRC EnvGen still does a single control period of interpolation if a segment time is 0, so it would be good to catch this case, I think.
| inEnvir { |envir| | ||
| envir ?? { envir = currentEnvironment }; | ||
| ^{ |... args| envir.use({ this.valueArray(args) }) } | ||
| } | ||
|
|
||
| loadToFloatArray { arg duration = 0.01, server, action; | ||
| var buffer, def, synth, name, numChannels, val, rate; | ||
| asBuffer { |duration = 0.01, server, action, fadeTime| |
There was a problem hiding this comment.
see my note above about using fadeTime = 0
|
|
||
| ^buffer | ||
|
|
||
|
|
There was a problem hiding this comment.
could you please remove the extra whitespace here?
| loadToFloatArray { arg duration = 0.01, server, action; | ||
| var buffer, def, synth, name, numChannels, val, rate; | ||
| asBuffer { |duration = 0.01, server, action, fadeTime| | ||
| var buffer, def, synth, name, numChannels, rate; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2996.