Classlib: MIDISysexDispatcher keys must be an array, not a large integer #3005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getKeysForFuncProxy
should always return a collection, because of where it's used:https://github.com/supercollider/supercollider/blob/master/SCClassLibrary/Common/Control/ResponseDefs.sc#L131-L132
All of the other MIDI***Dispatcher classes do
asArray
in getKeysForFuncProxy... MIDISysexDispatcher, uniquely, does not:So, when the srcID is a very large integer,
keys
becomes a large integer, and thenkeys.do
will add a new item intoactive
that number of times. Millions of times. Potentially-crashy numbers of times.Fixes #2937.