Improved checking of freed Busses #2993
Conversation
SCClassLibrary/Common/Control/Bus.sc
Outdated
| @@ -55,6 +55,7 @@ Bus { | |||
| } | |||
|
|
|||
| setMsg { arg ... values; | |||
| if(index.isNil) { Error("Cannot construct a % for a % that has been freed".format(thisMethod.name, this.class.name)).throw }; | |||
| if(this.isSettable, { | |||
There was a problem hiding this comment.
it would be good if you keep the same formatting convention in the whole document. So maybe if you like you could change if(this.isSettable, { … to if(this.isSettable) { …
There was a problem hiding this comment.
Good point. What is the current preferred syntax for if statements? I don't mind making these changes.
SCClassLibrary/Common/Control/Bus.sc
Outdated
| @@ -69,11 +70,14 @@ Bus { | |||
| ["/c_setn", index, values.size] ++ values); | |||
| }, { error("Cannot set an audio rate bus") }); | |||
There was a problem hiding this comment.
and while you are at it, you could remove the trailing semicolons: }, { error("Cannot set an audio rate bus") })
There was a problem hiding this comment.
I can remove the trailing semicolons np.
|
can someone label this PR, and also mark it for revisions? |
|
If there are any more stylistic tweaks to be made, please let me know. |
|
@snappizz I think this is ready for your final approval. |
This PR improves checking for nil Busses. It also replaces a call to
.getnMsgwith it's corresponding server message.