SCDoc: make each category breadcrumb a separate link #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, Cat>Subcat>Subsubcat would be one link. Now, each part of that path is a separate link, with Cat going to Cat, Subcat going to Cat>Subcat, etc.
mossheim
added
the
comp: SCDoc
|
Tested and it works here 👍 Visually, it can be a little confusing when a help file belongs to multiple categories (ex: ServerTiming.schelp). Would it be a good idea to have a little more spacial separation between them? |
|
Here are a few more options. What do you think?
|
|
@brianlheim my vote goes to the pipes |
|
I'm also a fan of the pipes. :) I think I should increment the help version number just to be safe, does anyone disagree? |
|
sure thing. i had no idea it had a version number tbh |
|
Great! Both things are done now. I think incrementing is a good move since without it, the docs won't get rerendered and you wouldn't see the change. Shoutout to @patrickdupuis for making me aware of that. |
nhthn
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692.
Before, Cat>Subcat>Subsubcat would be one link. Now, each part of that
path is a separate link, with Cat going to Cat, Subcat going to
Cat>Subcat, etc.
Should I also increment the version number is SCDoc? (https://github.com/supercollider/supercollider/blob/master/SCClassLibrary/SCDoc/SCDoc.sc#L363)