class lib: don't post "cleaning up temp synthdefs" if no SynthDefs are being cleaned up #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of an effort to clean up initial post window output, this commit causes the "Cleaning up temp synthdefs..." post window output to be suppressed if there are no temporary SynthDefs to clean up. For most users, this gets rid of the message entirely, since most SynthDefs today are done in memory. It also revises the message to "Cleaning up temporary SynthDefs...".
jamshark70
reviewed
Jan 11, 2017
There was a problem hiding this comment.
I would change line 23 as well: having saved the result of pathMatch(path) in a variable, it's wasted effort to do it again.
For that matter, why is the do not inside the if branch? If match is empty, sure, do is a no-op... but in that case, it's redundant to call it (especially since we've just checked).
How about printing how many temp SynthDefs were cleaned up, too?
This commit amends the "Cleaning up temporary SynthDefs..." post message to display the number of SynthDefs being cleaned up. It also has a very minor refactor so that "pathMatch" is called only once, and "match.do" is not called if the match is empty.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users use SynthDefs in memory, so there are no SynthDef files to be cleaned. This commit suppresses the "cleaning up temp synthdefs" message if it's not doing anything. I also capitalized "SynthDefs" and expanded "temp" to "temporary."