Classlib: Fix IDict collect, select, reject to keep parent, proto and know #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… know Also, clarify documentation and fix a broken link.
telephon
approved these changes
Nov 20, 2016
|
|
||
| list:: | ||
| ## code::proto:: and code::parent:: values are not shown when posting the dictionary. | ||
| ## Copying an IdentityDictionary transfers a reference to the parent and proto into the copy. It is a reference, not a copy: changing the copy's parent also affects the parent of the original. This is for efficiency. |
There was a problem hiding this comment.
(suggestion:)
this is more efficient than a deep copy, and also allows to inherit the dynamic relation to the parent.
| list:: | ||
| ## code::proto:: and code::parent:: values are not shown when posting the dictionary. | ||
| ## Copying an IdentityDictionary transfers a reference to the parent and proto into the copy. It is a reference, not a copy: changing the copy's parent also affects the parent of the original. This is for efficiency. | ||
| ## Looping operations (link::Classes/Dictionary#-do::, link::Classes/Dictionary#-keysValuesDo::) only touch the main-level values. |
There was a problem hiding this comment.
technically this is iteration, no?
| e[\a] + e[\b] | ||
| -> 15 | ||
|
|
||
| // Looping touches 'a' only |
There was a problem hiding this comment.
again, I wouldn't have understood this as looping, but that may only be me.
| reject { arg function; | ||
| var res = this.class.new(this.size, proto, parent, know); | ||
| this.keysValuesDo { arg key, elem; if(function.value(elem, key).not) | ||
| { res.put(key, elem) } } |
nhthn
added
comp: class library
|
I've pushed to the branch to address @telephon's issues, so this is ready to merge. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, clarify documentation and fix a broken link.
Fixes #2499.