-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sclang and server recover more gracefully #2453
Merged
adcxyz
merged 22 commits into
supercollider:master
from
telephon:topic-server-recover-more-gracefully
Dec 3, 2016
Merged
sclang and server recover more gracefully #2453
adcxyz
merged 22 commits into
supercollider:master
from
telephon:topic-server-recover-more-gracefully
Dec 3, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the display of the recording time in the IDE gui. It also adds a hook to the pause and resume recording functions.
For the server GUI window, the SimpleController should take the view as dependant.
This is symmetric to `register`.
Stethoscope calls `serverTree` already.
- a minor API change: the methods called on Volume are adopted to standard usage: numChans (deprecated) is now numChannels. - refactoring of the code, use method instead of function for update.
This is a rather large refactoring, but because of its interdependencies is hard to dissect into pieces. – move functionality between Server and NetAddr - simplify Buffer allocation methods - unify code formatting - move recording functionality to recorder class - moves recording defaults to ServerOptions - makes hack unnecessary for reserved recording buffers - print more informative messages - deprecates the `set_` class method (replaced by `all_` already long ago).
This reverts commit e8879ba.
Same as supercollider#2405, but keeps this branch functional.
The server model checks before boot if it can reach its address. If this works, it quits the server app first, so that it doesn’t run into duplicate clientIDs. This allows us to recover better when sclang has crashed and couldn’t release its server notification id and its shared memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit (just the last of this branch) is based on the branch for #2422. It is a first attempt at making a more graceful restart of the sclang interpreter after a crash.
This fixes #2397.