Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing filepath at end of recording #2435

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Fix printing filepath at end of recording #2435

merged 1 commit into from
Nov 4, 2016

Conversation

bagong
Copy link
Contributor

@bagong bagong commented Oct 27, 2016

issue #2432

@nhthn nhthn added this to the 3.8 milestone Oct 28, 2016
@nhthn nhthn added the comp: class library SC class library label Oct 28, 2016
@telephon
Copy link
Member

Looks good. But maybe instead we could finally dare to merge #2422 ? Need to check why there was a travis failure though.

Maybe you can have a brief review of the code.

@crucialfelix
Copy link
Member

We can't merge #2422 in 3.8, we are already in beta. It's probably about ready for master though.

@telephon telephon modified the milestones: 3.9, 3.8 Oct 31, 2016
@bagong
Copy link
Contributor Author

bagong commented Nov 4, 2016

I think this guy can't do any harm? It's just what get's printed at the end of a recording? Not that it's important, but it's not in conflict with #2422. Maybe the milestone was changed by accident?

@crucialfelix crucialfelix modified the milestones: 3.8, 3.9 Nov 4, 2016
@crucialfelix crucialfelix merged commit cb6ca48 into supercollider:3.8 Nov 4, 2016
@crucialfelix
Copy link
Member

I just missed that it was on 3.8 branch. thanks for spotting it !

@bagong bagong deleted the recordPath branch February 6, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp: class library SC class library
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@bagong @telephon @crucialfelix @nhthn