class library and ide: refactor server #2422

telephon · 2016-10-22T19:37:55Z

Here is the last version of the server refactoring.

This commit fixes the display of the recording time in the IDE gui. It also adds a hook to the pause and resume recording functions.

For the server GUI window, the SimpleController should take the view as dependant.

This is symmetric to `register`.

Stethoscope calls `serverTree` already.

- a minor API change: the methods called on Volume are adopted to standard usage: numChans (deprecated) is now numChannels. - refactoring of the code, use method instead of function for update.

This is a rather large refactoring, but because of its interdependencies is hard to dissect into pieces. – move functionality between Server and NetAddr - simplify Buffer allocation methods - unify code formatting - move recording functionality to recorder class - moves recording defaults to ServerOptions - makes hack unnecessary for reserved recording buffers - print more informative messages - deprecates the `set_` class method (replaced by `all_` already long ago).

This reverts commit e8879ba.

Same as supercollider#2405, but keeps this branch functional.

telephon · 2016-10-27T22:00:58Z

I don't understand why this failed. The error is �[31mError:�[0m python-2.7.12_1 already installed. Nothing to do with this PR, really.

bagong · 2016-10-28T13:15:47Z

Retriggering the build "fixed" it ;)

telephon · 2016-10-28T15:41:56Z

excellent.

nhthn · 2016-10-28T16:00:45Z

What should I look for testing this PR?

nhthn · 2016-10-28T16:05:29Z

HelpSource/Classes/Recorder.schelp

+argument::server
+
+
+InstanceMethods::


Two small doc warnings:

WARNING: SCDoc: In /home/nathan/git/supercollider/HelpSource/Classes/Recorder.schelp Method -prepareForRecord has 2 args, but doc has 1 argument:: tags. WARNING: SCDoc: In /home/nathan/git/supercollider/HelpSource/Classes/Recorder.schelp Method -record has 5 args, but doc has 1 argument:: tags.

telephon · 2016-10-28T18:13:31Z

@snappizz: A lot of the server class functionality is refactored in this PR, but especially booting, quitting, recording, scoping, pause and resume recording, both programmatically and from the IDE menus would be possible places to look at.

In terms of code quality, the C++/Qt code may need more eyes perhaps.

telephon · 2016-10-30T20:26:31Z

That's what I had thought as well, but when I call killall scsynth from the terminal, I also see it.

jamshark70 · 2016-10-31T02:11:31Z

We can turn it off by setting postOutput to false

It would be worth testing to be sure this doesn't suppress error posting from scsynth. I believe postOutput: false will block all stdout, and that would be bad.

telephon · 2016-10-31T18:13:12Z

For what this PR is concerned, I'm rather curious to know where the posting comes from. It could be used at least for local servers to detect a killed server.

nhthn · 2016-10-31T19:00:13Z

I have filed #2452 concerning the inability to disable RESULT = posting without disabling post output entirely.

You can detect a killed server using the action argument to unixCmd.

telephon · 2016-10-31T20:11:29Z

You can detect a killed server using the action argument to unixCmd.

Yes, but only if you have called the command from sclang. Make the following experiment:

Open the terminal (bash or whatever) and type killall scsynth. Then look in the post window of sclang. You'll (probably) see RESULT = 0. Why is that!?

nhthn · 2016-10-31T23:22:13Z

I think we keep talking past each other here... never mind.

Thanks for your work on this, I'm excited to get this merged. Let's get at least one thorough code review in before merging. Sound good?

I can go over it on Saturday, and of course everyone else should feel free to step up.

telephon · 2016-11-01T07:08:04Z

… yes, never mind.

sounds good!

telephon · 2016-11-01T10:05:52Z

Ah, now I got it: because sclang actually creates the process using a unixCmd, we can also test for an end.

see #2458.

telephon · 2016-11-12T20:07:50Z

ping …

nhthn · 2016-11-13T04:22:58Z

sorry i didn't get around to code review as promised :( pretty busy for the next few days unfortunately

telephon · 2016-11-13T08:04:49Z

no problem, just wanted to keep this awake :)

adcxyz

Looks like a big improvement - code is much clearer than it was, and better organized.
Testing for a few hours, no problems found; will test for a few more days.

nhthn · 2016-11-29T16:53:43Z

I swear I will get around to code review for this at some point, but right now I'm behind on work and school.

telephon · 2016-11-29T18:20:12Z

@snappizz no Problem, this is just for keeping it alive. if others can test too, it wouldn't hurt

adcxyz · 2016-11-29T18:26:45Z

I have browsed through it, and it looks really good. Will test for a few more days - it feels very complete and mergeable already. best adc

…

On 29/11/2016, at 19:20 , Julian Rohrhuber ***@***.***> wrote: @snappizz no Problem, this is just for keeping it alive. if others can test too, it wouldn't hurt — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

jamshark70 · 2016-11-30T05:01:13Z

#2521. It was only a matter of time before we got caught with pants around ankles.

telephon · 2016-11-30T09:30:23Z

that is a rather drastic metaphor for code review, james!

jamshark70 · 2016-12-01T02:04:28Z

Oh, heh heh, it's a modified version of the American idiom "(to) get caught with your pants down," meaning to be unprepared for something that you knew was coming up and should have been ready to do. It seemed apt (if colorful).

telephon added 16 commits September 29, 2016 21:38

ide: pause recording and fix display recording time

6c2e667

This commit fixes the display of the recording time in the IDE gui. It also adds a hook to the pause and resume recording functions.

class library: move status watcher in GUI

c19fb83

For the server GUI window, the SimpleController should take the view as dependant.

class library: unregister message for Node

623de33

This is symmetric to `register`.

class library: improvements to server status watcher

8edc2d7

class library: clean up code

76bc699

class library: avoid double initialisation of scope

61da9f2

Stethoscope calls `serverTree` already.

class library: refactor volume GUI class

25657a7

- a minor API change: the methods called on Volume are adopted to standard usage: numChans (deprecated) is now numChannels. - refactoring of the code, use method instead of function for update.

class library: add recorder class

f9525ae

help: improve server related helpfiles

3be1b50

help: remove conflict marker

3c67bff

class library: remove spaces, add tabs

760ff15

help: remove diff artefact

503407e

class library: don't set client id but warn.

e8879ba

Revert "class library: don't set client id but warn."

bb1fcd8

This reverts commit e8879ba.

class library: fail to notify server doesn't set clientID

c140003

Same as supercollider#2405, but keeps this branch functional.

telephon added env: SCIDE comp: class library SC class library labels Oct 22, 2016

telephon added this to the 3.9 milestone Oct 22, 2016

telephon mentioned this pull request Oct 27, 2016

s.stopRecording posts "nil" instead of the file path (Win-3.8.0-beta1) #2432

Closed

telephon mentioned this pull request Oct 27, 2016

class library: deprecate String:inform #2427

Closed

class library: recorder posts file name when stopping

deb145e

telephon mentioned this pull request Oct 28, 2016

Fix printing filepath at end of recording #2435

Merged

nhthn requested changes Oct 28, 2016

View reviewed changes

help: improve Recorder helpfile

214495c

telephon mentioned this pull request Oct 31, 2016

sclang and server recover more gracefully #2453

Merged

This was referenced Oct 31, 2016

server allows multiple recorders #2454

Merged

Cpu hog 100% by sclang when it's built without QT #2144

Closed

record bus made easier #2455

Merged

telephon mentioned this pull request Nov 1, 2016

server graceful force quit #2458

Merged

bagong mentioned this pull request Nov 8, 2016

Merge commits from 3.8 release branch #2486

Merged

telephon changed the title ~~server refactoring reordered~~ class library and ide: refactor server Nov 12, 2016

nhthn self-assigned this Nov 22, 2016

adcxyz approved these changes Nov 28, 2016

View reviewed changes

adcxyz merged commit 6a3f37e into supercollider:master Dec 2, 2016

adcxyz mentioned this pull request Dec 2, 2016

Server window GUI not reflecting activity in 3.8 #2521

Closed

nhthn mentioned this pull request Jan 15, 2017

VolumeGui updates in wrong thread #2292

Closed

mossheim mentioned this pull request Jan 15, 2017

Server refactoring reordered #2366

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

class library and ide: refactor server #2422

class library and ide: refactor server #2422

telephon commented Oct 22, 2016

telephon commented Oct 27, 2016

bagong commented Oct 28, 2016

telephon commented Oct 28, 2016

nhthn commented Oct 28, 2016

nhthn Oct 28, 2016

telephon Oct 28, 2016

telephon commented Oct 28, 2016

telephon commented Oct 30, 2016

jamshark70 commented Oct 31, 2016

telephon commented Oct 31, 2016

nhthn commented Oct 31, 2016

telephon commented Oct 31, 2016

nhthn commented Oct 31, 2016

telephon commented Nov 1, 2016 •

edited

Loading

telephon commented Nov 1, 2016

telephon commented Nov 12, 2016

nhthn commented Nov 13, 2016

telephon commented Nov 13, 2016

adcxyz left a comment

nhthn commented Nov 29, 2016

telephon commented Nov 29, 2016

adcxyz commented Nov 29, 2016 via email

jamshark70 commented Nov 30, 2016

telephon commented Nov 30, 2016

jamshark70 commented Dec 1, 2016

		argument::server


		InstanceMethods::

class library and ide: refactor server #2422

class library and ide: refactor server #2422

Conversation

telephon commented Oct 22, 2016

telephon commented Oct 27, 2016

bagong commented Oct 28, 2016

telephon commented Oct 28, 2016

nhthn commented Oct 28, 2016

nhthn Oct 28, 2016

Choose a reason for hiding this comment

telephon Oct 28, 2016

Choose a reason for hiding this comment

telephon commented Oct 28, 2016

telephon commented Oct 30, 2016

jamshark70 commented Oct 31, 2016

telephon commented Oct 31, 2016

nhthn commented Oct 31, 2016

telephon commented Oct 31, 2016

nhthn commented Oct 31, 2016

telephon commented Nov 1, 2016 • edited Loading

telephon commented Nov 1, 2016

telephon commented Nov 12, 2016

nhthn commented Nov 13, 2016

telephon commented Nov 13, 2016

adcxyz left a comment

Choose a reason for hiding this comment

nhthn commented Nov 29, 2016

telephon commented Nov 29, 2016

adcxyz commented Nov 29, 2016 via email

jamshark70 commented Nov 30, 2016

telephon commented Nov 30, 2016

jamshark70 commented Dec 1, 2016

telephon commented Nov 1, 2016 •

edited

Loading