Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: don't set client id on failure #2405

Merged
merged 2 commits into from
Nov 4, 2016
Merged

server: don't set client id on failure #2405

merged 2 commits into from
Nov 4, 2016

Conversation

telephon
Copy link
Member

don't set client ID if notify failed, and throw an error.

This fixes #2328. Related to #1914.

@telephon
class library: don't set client ID if notify failed
0acbb86 
don't set client ID if notify failed, and throw an error.
@telephon telephon closed this Oct 14, 2016
@telephon telephon deleted the topic-dont-set-clientID-on-failure branch October 14, 2016 19:09
@telephon telephon restored the topic-dont-set-clientID-on-failure branch October 14, 2016 19:13
@telephon telephon reopened this Oct 14, 2016
@telephon
Copy link
Member Author

@crucialfelix wrote:

There is no scserver it is scsynth.

Actually it may be supernova.

Since the clientID is necessary for all of the node id allocators, you have to throw an error here and halt. You cannot use the server, everything must stop. This is not a warning - it is fatal.

So there remains the problem of a very ungraceful recovery from rebooting the interpreter in the IDE. Do you have a better way to do this on Atom?

@telephon
Copy link
Member Author

I've modified the message accordingly.

telephon added a commit to telephon/supercollider that referenced this pull request Oct 14, 2016
@telephon
class library: fail to notify server doesn't set clientID
c140003 
Same as supercollider#2405, but keeps this branch functional.
@nhthn nhthn added the comp: class library SC class library label Oct 22, 2016
@crucialfelix crucialfelix added this to the 3.8 milestone Nov 4, 2016
@crucialfelix crucialfelix added the bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. label Nov 4, 2016
@crucialfelix crucialfelix merged commit 5ddd75a into supercollider:3.8 Nov 4, 2016
@crucialfelix crucialfelix mentioned this pull request Nov 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: class library SC class library
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@telephon @crucialfelix @nhthn