Handle spaces in SCDoc internal links #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: editors/scvim
…c-internal-links * snappizz-scdoc-internal-links: Add encodeURIComponent to toc links SCDoc: Escape spaces in named anchors (use %20 instead) # Conflicts: # SCClassLibrary/SCDoc/SCDocRenderer.sc
|
This is still a bug: renders as: But the link is correctly escaped and is clickable but the text should not have been. This is the case where there is only an anchor. See: I think that should be a new bug to fix. Let's merge this and move on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflict fixed from #2135 and reposted here