Add linting and fix classlib indention #2298
Conversation
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
|
Yay ! Thanks for doing this. We should convert scdocrendere too. Is it because of html in the class file ? |
@crucialfelix no, it appears to be the only file using spaces instead of tabs in the class library. |
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
|
@crucialfelix done |
|
If anyone wants to review the non-whitespace changes, here ya go |
|
@crucialfelix I'd be willing to add linting for CMakeLists.txt files as well but it's a bit messy right now so it might be better in another PR. |
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
|
yeah, let's do that later. and the cpp code too. shit, this one already has a conflict. I wanted to wait on it because the PRs that I'm merging now might cause a failure after they merge (and the linter is added). |
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
| @@ -22,8 +22,8 @@ TGrains : MultiOutUGen { | |||
| *ar { arg numChannels, trigger=0, bufnum=0, rate=1, centerPos=0, | |||
| dur=0.1, pan=0, amp=0.1, interp=4; | |||
| if (numChannels < 2) { | |||
| "TGrains needs at least two channels.".error; | |||
| ^nil | |||
| "TGrains needs at least two channels.".error; | |||
There was a problem hiding this comment.
this is the conflict. I just merged a pr that removes this if check
|
@crucialfelix I fixed the conflict and now travis build is gonna fail fast (on linux) if there are any linting errors. |
crucialfelix
added
comp: class library
|
I guess we should do this now. The only reason I was thinking to wait was because of other PR that will still be merged that might re-introduce spaces. If one does get through then master errors and we have to just jump in and fix up the spaces. No big deal. I will merge tomorrow if nobody speaks against it. |
This adds linting (for indention) as well as some indention fixes in the class library only.
Note thatSCDocRenderer.scis excluded as it was the only file which uses spaces there.Travis runs the lint command and the build (on linux) will
eventuallyfail fast if indention is broken in the class library.(on travis linting is only run on linux because osx-ci uses bash-3 which does not support ** wildcard)
Re #2094