Classname as Selector crashes #2166
Conversation
…eaning 1 Object: 2 crashes. This resolves that by checking.
|
Oh also (and apologies for not have found this in the doc): I have small test cases I used to make sure this worked of course. Is there a way I can add those to standard regtest suite for SC? It wasn't clear to me from the developer doc. Hope you can tolerate the newbie question! |
|
Yes please post the test case. What a silly bug you've found ! You can add it to the test suite, but after the fix is in so that Travis Thanks On Sunday, June 5, 2016, baconpaul notifications@github.com wrote:
|
|
Great. I'm really sorry, where do I commit it and how do I get it introduced into the suite? I can do that as another pull request when this one is merged. Happy to just read a doc but I can't find it, and the test suite directory in my fork looks tiny. Oh and I didn't find the bug; I just fixed it. Someone else deserves credit for filing a bug report with a clear repo! I picked up a couple this weekend that looked tractable so I could learn the code some and set up my dev environment. Thanks |
|
re the test suite: it is here https://github.com/supercollider-quarks/CommonTests |
|
Got it. Once this is merged I'll send a pull request for the updated Methods test. Thanks very much! |
|
Thanks for merging! Here's the test pull request to match. supercollider-quarks/CommonTests#6 |
crucialfelix
added
bug
This fixes #669
1 Object: 2
If you use a registered classname as a selector it would think it was a method, but resolve the object as the symbol and not check. Then if it actually looked it up you got segfaulted.
So this checks and puts you in the same error path that you get with
1 FooBazNotObject: 2
or
1 fooBazNotAMethod: 2