Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpfile fixing #2061

Merged
merged 16 commits into from
May 11, 2016
Merged

Helpfile fixing #2061

merged 16 commits into from
May 11, 2016

Conversation

LFSaw
Copy link
Member

@LFSaw LFSaw commented May 9, 2016

updates/additions of several helpfiles

tapage and others added 14 commits May 8, 2016 15:33
This should go in the helpfile of: OSXPlatform:

method::preferencesAction
note::SCApp only!::

A function to evaluate when the SuperCollider preferences menu is selected.

code::
thisProcess.preferencesAction = { arg process; SCWindow.new.front; }
::
removed method::preferencesAction
fixed naming startframe & aSoundFile
prReadDirectoryFile private, added done as arg
added Pmul arguments name & pattern
…viour" (#2056)

This reverts commit 381a3ff which was based on a wrong assumption. All is well!
…y folding when modulated. (#2053)

* Helpfile fixing (#2042)

* fixed SinOsc helpfile

* Added closeWhenDone to .cue

* add args for Tdef.fork and .play in help file.

* remove obsolete SCView subclass

* add missing args to help file

* change link to Republic to just text.

* LFSaw.schelp: Note and example for special initial-phase behaviour

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>

* RLPF.schelp: replace FSinOsc with SinOsc to avoid erratic amplitudes and exploding filter.

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>
* Klank.schelp: improved examples

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>

* DynKlank.schelp: corrected statement about realtime-ness of Dynklank, split up examples

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>
@LFSaw
Copy link
Member Author

LFSaw commented May 9, 2016

I'd like to then close this branch. Working on helpfiles should continue also off the effort made here: http://piratepad.net/Nx0YRDmchh

miczac and others added 2 commits May 11, 2016 03:07
Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>
Pulse.schelp: added missing .kr method, beautified examples
@crucialfelix
Copy link
Member

You guys are merging pull requests into pull requests. That's crazy.

I already merged #2069 into master.

@crucialfelix crucialfelix merged commit 20888e6 into master May 11, 2016
@crucialfelix crucialfelix added the comp: help schelp documentation label May 11, 2016
@crucialfelix crucialfelix added this to the 3.8 milestone May 11, 2016
@crucialfelix
Copy link
Member

Nuts, I didn't notice your comment about closing this branch. Neither did miczac I guess.

This PR is merged in now. Duplicate commits shouldn't harm anything.

@LFSaw
Copy link
Member Author

LFSaw commented May 11, 2016

Appearantly There was some confusion about how to work with git... thanks for the merge!

@miczac
Copy link
Contributor

miczac commented May 11, 2016

allright .. so all new PRs should address master but the PP notes stay maintained?
I understood 'helpfile-fixing' as collection of improvements which is supposed to be merged every now and then and not every single PR being routed through it on a shorter-than-a-day basis.
There are many help files to be fixed and added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: help schelp documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants