-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsis: windows: add path information #2028
Conversation
This allows to open nicely with double click. Without this, the server is not found.
Thanks @llloret , it works! Sorry for the trouble, but I think it would be nice to add a line in the uninstall section the removes the new entry. I think this does it:
If I knew how to uninstall the firewall entries that accumulate on systems with multiple installs after a while, I'd do that as well... |
Umm, I added a commit for the uninstall yesterday night. Let me check. Yes, it is commit 4a247f8. |
Oh, sorry, I overlooked that!! Thank you!! |
@crucialfelix , the Work in Progress tag only refers to this: We plan to send out a test build and hope for some testing/feedback. Then Louis' PRs will have to go into 3.7 vanilla. Well, basically. The fourth one (open document with double click into already open SC) depend on Lucas' TCP-socket, so it will have to stay on the 3.7win branch, the three others are good for 3.7. This means that 3 out of 4 PRs will have to be moved before they can be committed. Louis or I will do the move, don't worry. Once they're moved we let you know that they are ready to be committed. Note that the by now maybe slightly misnamed "don't wait for keystroke" PR has cross platform effects. If we are lucky, it will solve the sclang shutdown issues on the other platforms as well. Which would mean close something like 10 issues at once... Of course it also means some testing on the other platforms wouldn't be bad either. |
@bagong go ahead and do the honors and merge this. I just want to be sure that we are juggling everything correctly and you know best. |
Sure, that remark above was general for all 4 PRs by Luis and directed as much to him as to you. I am not eager to merge, rather scared my intuition is wrong ;) But it works! ;) |
This allows to open nicely with double click. Without this, the server
is not found.