Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the required version Windows Vista #2016

Closed
wants to merge 1 commit into from

Conversation

llloret
Copy link
Member

@llloret llloret commented Apr 29, 2016

Make Windows Vista the minimum required version.

Some people are still using Windows Vista
@bagong
Copy link
Contributor

bagong commented Apr 30, 2016

@llloret , does anything immediate depend on this or would this be enough for master?

@llloret
Copy link
Member Author

llloret commented Apr 30, 2016

@bagong, that should be enough for master.

@bagong bagong added this to the 3.8 milestone Apr 30, 2016
@bagong
Copy link
Contributor

bagong commented Apr 30, 2016

So the PR should be moved to the master branch, sorry to say. We are currently in this unfortunate situation that working and testing is a lot easier on this branch, but the actual commits should go into the respective vanilla branches. But let's only do this, once the PR's are considered done. Give me a day or so for this one, I can build master using MinGW...

I wish we could find a solution to that IPC-problem that doesn't interfere with the other OSses. I'll try to inspect to which degree the Windows specific part of the general "Unicode" issue plays into this.

Would you mind me tagging the midi-PR as "work in progress, don't merge"? ;)

@llloret
Copy link
Member Author

llloret commented Apr 30, 2016

Sure, @bagong, you know what's the best way to organise this.

@bagong
Copy link
Contributor

bagong commented Apr 30, 2016

Just didn't want to appear impolite ;)

@bagong
Copy link
Contributor

bagong commented Apr 30, 2016

This is fine with master. So let's commit it to master. Will you redo the pull request yourself? (so much hassle for 1 letter ;) )

@llloret
Copy link
Member Author

llloret commented Apr 30, 2016

I'll do it later today.

@llloret llloret closed this Apr 30, 2016
@llloret llloret deleted the min_version_win_vista branch April 30, 2016 18:03
@llloret
Copy link
Member Author

llloret commented Apr 30, 2016

@bagong, I have created PR #2017 to merge into master.

@bagong
Copy link
Contributor

bagong commented Apr 30, 2016

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants