-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the required version Windows Vista #2016
Conversation
Some people are still using Windows Vista
@llloret , does anything immediate depend on this or would this be enough for master? |
@bagong, that should be enough for master. |
So the PR should be moved to the master branch, sorry to say. We are currently in this unfortunate situation that working and testing is a lot easier on this branch, but the actual commits should go into the respective vanilla branches. But let's only do this, once the PR's are considered done. Give me a day or so for this one, I can build master using MinGW... I wish we could find a solution to that IPC-problem that doesn't interfere with the other OSses. I'll try to inspect to which degree the Windows specific part of the general "Unicode" issue plays into this. Would you mind me tagging the midi-PR as "work in progress, don't merge"? ;) |
Sure, @bagong, you know what's the best way to organise this. |
Just didn't want to appear impolite ;) |
This is fine with master. So let's commit it to master. Will you redo the pull request yourself? (so much hassle for 1 letter ;) ) |
I'll do it later today. |
Cool! |
Make Windows Vista the minimum required version.