-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build system #1900
Windows build system #1900
Conversation
…rtaudio to old state
Bit thanks to JOACH and KOS from k-o-l-e-k-t-i-v for their testing, determination and inspiring discussion!
Awesome. I'll leave this for a day to let somebody who knows cmake well to also have a glance. I checked it through a bit too. portaudio is a submodule now, right ? |
Yes, portaudio is a submodule. It already was since that previous build system related commit, but in this version it is obligatory for Windows. Keeping the options of both building portaudio as part of the SC build or providing libraries compiled outside of SC made subsequent code a lot more complicated and intransparent. Since the audio APIs provided now are the same than you would get from a portaudio build outside of SC I thought this was the preferable way. To come back to the question of where that submodule/pa-fork should reside: I'd actually prefer to see it in the SC repo, not because of any burden it creates while it's in my repo, but because if people wanted to commit to the fork, they'd have to go through my repo. That would make me kind of a gate-keeper of portaudio on SC, something I'd prefer not to be... |
okay, let's fork from yours into the supercollider org. |
Great! Should I do it, or will you? It's not urgent, of course... |
This basically does three things:
The readme-Windows is adjusted and contains quite a few enhancements and corrections of errors. Thanks to Joach and Kos for testing and discussing!