Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build system #1900

Merged
merged 8 commits into from
Mar 17, 2016
Merged

Windows build system #1900

merged 8 commits into from
Mar 17, 2016

Conversation

bagong
Copy link
Contributor

@bagong bagong commented Mar 16, 2016

This basically does three things:

  • switches to using embedded portaudio only (by adding the portaudio to the beginning of the compile all audio api's can be built now)
  • allow to run/debug executable targets without installing
  • reduce the risk of wrong library finds both in the beginning (find-modules) and at the end (fixup-bundle)

The readme-Windows is adjusted and contains quite a few enhancements and corrections of errors. Thanks to Joach and Kos for testing and discussing!

@crucialfelix crucialfelix added this to the 3.7.1 milestone Mar 17, 2016
@crucialfelix crucialfelix self-assigned this Mar 17, 2016
@crucialfelix
Copy link
Member

Awesome. I'll leave this for a day to let somebody who knows cmake well to also have a glance. I checked it through a bit too.

portaudio is a submodule now, right ?

@bagong
Copy link
Contributor Author

bagong commented Mar 17, 2016

Yes, portaudio is a submodule. It already was since that previous build system related commit, but in this version it is obligatory for Windows. Keeping the options of both building portaudio as part of the SC build or providing libraries compiled outside of SC made subsequent code a lot more complicated and intransparent. Since the audio APIs provided now are the same than you would get from a portaudio build outside of SC I thought this was the preferable way.

To come back to the question of where that submodule/pa-fork should reside: I'd actually prefer to see it in the SC repo, not because of any burden it creates while it's in my repo, but because if people wanted to commit to the fork, they'd have to go through my repo. That would make me kind of a gate-keeper of portaudio on SC, something I'd prefer not to be...

@crucialfelix
Copy link
Member

okay, let's fork from yours into the supercollider org.

@bagong
Copy link
Contributor Author

bagong commented Mar 17, 2016

Great! Should I do it, or will you? It's not urgent, of course...

crucialfelix added a commit that referenced this pull request Mar 17, 2016
@crucialfelix crucialfelix merged commit 2c0713c into supercollider:3.7 Mar 17, 2016
@bagong bagong deleted the winbuild branch March 17, 2016 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants