sclang: Fix to get Object: render to work on Windows #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to reliance on "rm" command render invocations such as the one below threw an error on Windows. Pbind(\instrument, \default).render(thisProcess.platform.recordingsDir +/+ "test.aif", 1) Error is "ERROR: Invalid option ;" from scsynth.exe. Instead of "rm" I propose to rely on File.delete instead.
|
looks clear enough |
|
Fab! A Windows fix! We need you, man ;) |
crucialfelix
added a commit
that referenced
this pull request
Mar 17, 2016
sclang: Fix to get Object: render to work on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to reliance on "rm" command for oscfile removal invocations of Object: render such as the one below threw an error on Windows.
Pbind(\instrument, \default).render(thisProcess.platform.recordingsDir +/+ "test.aif", 1)
The error you get on Windows is "ERROR: Invalid option ;" thrown from scsynth.exe.
I propose to rely on File.delete instead of "rm".