Don't merge this yet !

I will make the PR with the merge to master first.
Then we can keep 3.7 branch o_pen but only for critical bug fixes._
Lets try to not make an endless series of point releases with small bugs
and changes.
Rather we should work towards a 3.8 that isn't so epic.
Do we all agree on that strategy ?

*Though I *suppose you can't create a Debian package for 3.7.0 without this.
Right ?

We could move the tag if that's the case.

Ignore the underlines in the text. It's just my iPad being sloppy.

On Wednesday, March 16, 2016, danstowell notifications@github.com wrote:

Found this while packaging for debian. Fixes a small bug that prevents

build if cmake boost is found.

You can view, comment on, or merge this pull request online at:

#1896
Commit Summary

• cmake: fix build when using system boost

File Changes

• M external_libraries/CMakeLists.txt
  https://github.com/supercollider/supercollider/pull/1896/files#diff-0
  (5)

Patch Links:

• https://github.com/supercollider/supercollider/pull/1896.patch
• https://github.com/supercollider/supercollider/pull/1896.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1896

This fix should go to both 3.7 and to master IMO. For packaging 3.7.0 debian the fix is absolutely needed so I have applied it as a downstream patch, and the official standard way to go forward would be to upstream the patch into 3.7.1 (i.e. this PR).

For me, as long as the fix makes it into the 3.7 branch eventually and not master only, I don't really mind how it's managed. (Don't move the tag though, that's not good.)

okay, first I will do the PR for merging 3.7.0 into master.

then merge this into 3.7 branch

and it comes out in 3.7.1 which is in 2 or 3 weeks. at that point its merged also into master.

OK, thanks for being careful

3.7 merge is here: #1898