Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/release notes 3 7 0 #1791

Merged
merged 10 commits into from
Jan 18, 2016
Merged

Topic/release notes 3 7 0 #1791

merged 10 commits into from
Jan 18, 2016

Conversation

crucialfelix
Copy link
Member

Updated README files.
Also removes obsolete examples and fixes tabs vs spaces

Please read through and post your quibbles and comments.
Any changes for Linux or Windows please let me know and I can include them.

I'll merge this, but I'm interested in feedback.

@bagong
Copy link
Contributor

bagong commented Jan 15, 2016

Maybe this is the place to say it: I don't see a Windows 3.7 release happening. If nobody steps up that can actually do it (and not just moderate it, like me) it won't happen. I have given up maintaining my build system months ago and don't have the time to revive it fttb. Atm, from what I can see, there is no Windows version that builds, let alone works... Sorry.... Hopefully somebody can be found...

@crucialfelix
Copy link
Member Author

The call for a volunteer has certainly been made several times. We won't hold up the 3.7 release for windows. I can note it in the build instructions. If somebody can fix the issues then we can issue a point release (doesn't break any features).

@jamshark70 Don't you work on Window often ?

@telephon
Copy link
Member

I always build from command line.

I used to do that for most of the time, but then I couldn't navigate the project in xcode – it was very tedious, trying to do everything by "find" in the "finder". Is there a way to still build on command line even if you have configured the build for xcode?

danstowell
danstowell reviewed Jan 16, 2016
View reviewed changes
README_OS_X.md


Common arguments to control the build configuration are:

* Control the location where SC get's installed. The following line moves it to the Applications folder
* Control the location where SC get's installed. The following line moves it to the Applications folder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"get's" should be "gets"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(that's the only thing I could find to complain about in the pr...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@miczac
Copy link
Contributor

miczac commented Jan 17, 2016

great work, thanks!
A question regarding OS X: is there an agreement about a minimum OS X version?
README_OS_X.md states "Any build from the 6.x series or greater should generally work."
That implies running OS X 10.9 with XCode 6.1.1 minimum.
A note on that would be great, IMHO.

@crucialfelix
Copy link
Member Author

I wasn't sure about that myself. Maybe it does work all the way back to 10.7 and XCode 4.2.

travis is building with target: MAKE_OSX_DEPLOYMENT_TARGET=10.7
Travis CI uses OS X 10.9.5

I do know that I updated my XCode recently and it assumed that I was on El Capitan 10.11 (which I was valiantly resisting) and after that I couldn't compile anything. So I was forced to do the upgrade.

Can anybody here confirm building on 10.7 ?

@miczac
Copy link
Contributor

miczac commented Jan 17, 2016

hm, IFMP never had 10.7 and just upgraded from 10.8.5 to 10.9.5 (some simulator I need requires that).
And it gets a tad more complicated since supernova won't compile following the instructions as they are. Also not with with Xcode 6.2 (the newest one running on 10.9).
For lack of resources I couldn't yet test if a newer Xcode would solve this (probably 6.3.1?).
@timblechmann very briefly suggested [1] to use gcc, which alas yet is beyond my abilities to get the tool-chain cleanly adapted.
[1] #1636 (comment)
interestingly enough I can't remember where I got from that Xcode 6.1 would work.
In fact, it doesn't (just tried w/ 6.2 on 10.9.5)

@miczac miczac mentioned this pull request Jan 17, 2016
Merged
@miczac
Copy link
Contributor

miczac commented Jan 18, 2016

"Travis CI uses OS X 10.9.5"
well, I managed to test:
Supernova compiles OK on Xcode >= 6.3 (clang 6.1) which itself requires OS X 10.10.
I set a deployment target of 10.7 and compiled SC on a VM w/ 10.10 w/o problems.
Supernova compiled that way booted and sounded ok on native 10.9.
So, what to do regarding 3.7b and its Readme?
Either it's increasing the minimum OS X version to 10.10 (oh well ...) or add gcc as another prerequisite (or one just for Supernova) and adapt the cmake configuration accordingly.
IMHO not that nice either way...

@crucialfelix
Copy link
Member Author

Xcode 6 requires a Mac running OS X version 10.9.4 or later or 10.10
(you've proven that its compilable using xcode 6)

Xcode 5 requires a Mac running OS X v10.8.4
(we can say that it may work, no harm in trying)

On Mon, Jan 18, 2016 at 1:32 AM Michael Zacherl notifications@github.com
wrote:

Travis CI uses OS X 10.9.5
well, I managed to test:
Supernova compiles OK on Xcode >= 6.3 (clang 6.1) which itself requires OS
X 10.10.
I set a deployment target of 10.7 and compiled SC on a VM w/ 10.10 w/o
problems.
Supernova compiled that way booted and sounded ok on native 10.9.

So, what to do regarding 3.7b and its Readme?
Either it's increasing the minimum OS X version to 10.10 (oh well ...) or
add gcc as another prerequisite (or one just for Supernova) and adapt the
cmake configuration accordingly.
IMHO not that nice either way...

—
Reply to this email directly or view it on GitHub
#1791 (comment)
.

@crucialfelix crucialfelix added this to the 3.7.0 milestone Jan 18, 2016
@crucialfelix crucialfelix self-assigned this Jan 18, 2016
@crucialfelix
new generated CHANGELOG.md
edd9427 
This will be manually updated just before the actual 3.7.0 release.
It may contain some closed issues that will appear in post-3.7.0 releases
because there is currently no tag to generate up until.
@crucialfelix
Copy link
Member Author

I'd like to merge this today. Can I get an Amen ?

The CHANGELOG.md section for 3.7.0 will be regenerated just before the release. But it would be similar to this: https://github.com/crucialfelix/supercollider/blob/topic/release-notes-3-7-0/CHANGELOG.md

The previous ChangeLog stays there for now, but all the contents have been moved into CHANGELOG.md Or I can just remove it now.

I have not updated the News 3.7 schelp so its a bit thin. I am a bit worn out and I don't know what to put in there.

@danstowell
Copy link
Member

You are a TROOPER Mr Cruxxial, thanks for all your work! I just gave you a PR with a couple of notes for the news, if you like.

@crucialfelix
Copy link
Member Author

got it. merging now. will deal with a beta tag tomorrow. we can always add stuff to the news after the beta is out.

people have to kick the tires.

crucialfelix added a commit that referenced this pull request Jan 18, 2016
@crucialfelix
Merge pull request #1791 from crucialfelix/topic/release-notes-3-7-0
762508a 
Topic/release notes 3 7 0
@crucialfelix crucialfelix merged commit 762508a into supercollider:3.7 Jan 18, 2016
@crucialfelix crucialfelix deleted the topic/release-notes-3-7-0 branch January 18, 2016 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crucialfelix crucialfelix

Labels
comp: build CMake build system enhancement
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@crucialfelix @bagong @telephon @miczac @danstowell