-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example & help files: cleanup and streamlining of server handling #1728
Conversation
ah, actually I think its better to leave these as explicit. I thought we were talking about entirely removing but to rely on knowing that s is usually / by default set to Server.default is more mysterious. principal of least surprise: "oh duh, I forgot to turn it on" vs "what the hell is this s thing ? why do these people hide things from me ?" |
if we have "oh dude, look my nice patch: s = Synth(\default, [\freq, 8000]);" That would be unfortunate ... |
ok, you lost me here: leave what as explizit? There's a variety of changes in this 49 files. |
@telephon , I took the special meaning as given, also as in "s is set once and for good" (in Main.sc). |
I completely agree.
yes, please change them as you proposed! It was just
maybe not (at least this is what I tend toward)
Nothing, I think. |
yes! |
revised HelpSource/Tutorials/Tutorial.schelp |
ok, consistency is best. the changes here are fine with me. I just made one note about not using a ~var |
great, thanks! I'll change that and push again. |
ok, basically done, but I discovered I stated wrongly when saying at |
OT side-note: git-gui (homebrew) crashes when entering a ~ in the commit message field. "copypasta" works though ;) |
changed comment on s at startup and pushed again. |
now consistant to s.boot and s.waitForBoot, adapted help text if applicable. removed .internal for Stethosope, it's not dependent on the internal server anymore. checked against dowhenbooted, waitforboot, server.internal, server.default and boot. omitted help files of Debugging-tips, ClientVsServer, asTarget, standalones, Server.
ok, pushed again ... ;) |
example & help files: cleanup and streamlining of server handling
thanks again, very welcome. |
np! |
now consistant to s.boot and s.waitForBoot, adapted help text if applicable.
removed .internal for Stethosope, it's not dependent on the internal server anymore.
checked against dowhenbooted, waitforboot, server.internal, server.default and boot.
omitted help files of Debugging-tips, ClientVsServer, asTarget, standalones, Server.