Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ass Filters: warning in help-docs about filter frequencies close to zero #1721

Merged
merged 1 commit into from
Nov 19, 2015

Conversation

miczac
Copy link
Contributor

@miczac miczac commented Nov 17, 2015

BPF LPF RLPF, RHPF., Resonz., BBandPass, BAllPass, BBandStop., BHiPass, BHiPass4, BLowPass, BLowPass4, BHiShelf, BLowShelf, BPeakEQ, BRF are potentially getting nasty at filter frequencies close to zero.
Somehow they didn't make it into the the PR for ce1d223

@miczac
Copy link
Contributor Author

miczac commented Nov 18, 2015

I realise there's no added value in having an individual commit per file, esp. for such a simple thing.
A side-effect when editing directly in the web-interface. I created a local copy of my fork and did a rebase, which I'd push to a new fork. How should the commit message look like? It would get rather long, like
"BPF, LPF, RLPF, RHPF, Resonz, BBandPass, BAllPass, BBandStop, BHiPass, BHiPass4, BLowPass, BLowPass4, BHiShelf, BLowShelf, BPeakEQ, BRF helpfiles: added warning about frequencies close to 0.
Related to ce1d223"

@timblechmann
Copy link
Contributor

wouldn't it be better to fix the filters?

@timblechmann
Copy link
Contributor

btw, do all those filters show this behaviour? iirc quantisation noise at low frequencies should be mainly a problem for high-pass (and possibly band-pass) filters ...

@crucialfelix
Copy link
Member

a good commit message would be "helpfiles: added warning about frequencies close to 0."

no need to list which files, that is easily apparent when looking at the commit.

as tim says, do check that this is the case for all of these. I don't remember having problems with LPF

@miczac
Copy link
Contributor Author

miczac commented Nov 19, 2015

indeed HP and BP are the ones prone to be screaming. I also tested against abrupt parameter changes which also can cause bad 0dBFs clicks and plops. Others, like SVF don't. Hence the wording.

@miczac
Copy link
Contributor Author

miczac commented Nov 19, 2015

regarding fixing the filters: I agree, even if it would cause to change behaviour of existing sc-code (IIRC we had that with 3.4 with the change to double-precision, which is something different, I know).
But, I think it's easy to revert this commit once the fix is completed.

@miczac
Copy link
Contributor Author

miczac commented Nov 19, 2015

@crucialfelix - would the commits in this PR be changed when I push the rebase to the fork or would I have to retract and re-issue?
edit: solved - it's one commit now.

crucialfelix added a commit that referenced this pull request Nov 19, 2015
help files: warning in filter UGen help files about filter frequencies close to zero
@crucialfelix crucialfelix merged commit cc3673f into supercollider:master Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants