fix #1668 - make existsCaseSensitive work for directories #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested on a case insensitive file system using this:
var pathName = "/Users/crucial/Library/Application Support/SuperCollider/downloaded-quarks/splines";
(pathName.dirname+/+"*").pathMatch.detect{|x|x.withoutTrailingSlash.compare(pathName.withoutTrailingSlash)==0}.notNil
|
To test this fix you can compare: set pathName to an existing directory previously returns false var pathName = "/Users/crucial/Library/Application Support/SuperCollider/downloaded-quarks/splines";
(pathName.dirname+/+"*").pathMatch.detect{|x|x.compare(pathName)==0}.notNilwith the fix it returns true var pathName = "/Users/crucial/Library/Application Support/SuperCollider/downloaded-quarks/splines";
// if the input has a trailing slash its still fine
// var pathName = "/Users/crucial/Library/Application Support/SuperCollider/downloaded-quarks/splines/";
(pathName.dirname+/+"*").pathMatch.detect{|x|x.withoutTrailingSlash.compare(pathName.withoutTrailingSlash)==0}.notNil |
crucialfelix
added a commit
that referenced
this pull request
Nov 7, 2015
fix #1668 - make existsCaseSensitive work for directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on a case insensitive file system using this:
var pathName = "/Users/crucial/Library/Application Support/SuperCollider/downloaded-quarks/splines";
(pathName.dirname+/+"*").pathMatch.detect{|x|x.withoutTrailingSlash.compare(pathName.withoutTrailingSlash)==0}.notNil