Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classlib: SystemSynthDefs: Clean up temp defs properly on all platforms #1627

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Classlib: SystemSynthDefs: Clean up temp defs properly on all platforms #1627

merged 1 commit into from
Aug 25, 2015

Conversation

jamshark70
Copy link
Contributor

"rm -f '/blah/blah/synthdefs/temp__*'".unixCmd was wrong for two reasons:

  1. Shell globbing isn't guaranteed to work with a quoted path. In Ubuntu, this failed to remove temp synthdef files.
  2. Not valid for Windows.

Solution: Get the paths via pathMatch and then use File.delete to remove them one by one.

telephon added a commit that referenced this pull request Aug 25, 2015
@telephon
Merge pull request #1627 from jamshark70/topic/tempSynthDefCleanup
5b4374b 
Classlib: SystemSynthDefs: Clean up temp defs properly on all platforms
@telephon telephon merged commit 5b4374b into supercollider:master Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamshark70 @telephon