Topic/fix scrollbar hiding osx #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telephon
added a commit
that referenced
this pull request
Jun 15, 2015
…g-osx Topic/fix scrollbar hiding osx
|
I could try this out on Windows (8.1-64 Qt5.4.2 (vanilla), VS64. I assume it works as it should/intended after making the build succeed by commenting out the #elif Q_OS_WIN line in ProxyStyle.cpp. The scrollbar behaviour in fact changes after the first mouse-wheel event, the scrollbar disappears/fades out. In my environment after this switch it is hard to recover the scrollbar though - I would expect it to reappear if hovering over the window border. I tried this with the Quarks.gui and and the scrollbar example in Window-help and I didn't find a way to make it reappear reliably. Certainly not a big issue... ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sclang honor the "Show scroll bars" preference on mac.
In addition, this works around cases on systems that either don't have a mouse wheel, or users that don't use it: in those cases, the scrollbars will auto-hide making scrolling hard to access / non-obvious. We default to always showing scrollbars until we receive a wheel event, at which point we allow normal hiding behavior. The BETTER solution here is to provide an AlwaysShowScrollbars() API for Windows and X11 that matches the mac API, so sclang follows the system-wide prefs. Ubuntu has a preferences for similar overlay scrollbars, and my GUESS is that Windows does as well - however, I can't find them, and don't have a system to easily test on. If any Win / Lin developers want to research this, it should be easy to modify from here.