Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sclang: print version with -v #1459

Merged
merged 5 commits into from
May 13, 2015
Merged

Sclang: print version with -v #1459

merged 5 commits into from
May 13, 2015

Conversation

gusano
Copy link
Member

@gusano gusano commented May 12, 2015

Re #1324 but that one uses -v instead

@gusano gusano added this to the 3.7 milestone May 12, 2015
@crucialfelix
Copy link
Member

build failure: https://travis-ci.org/supercollider/supercollider/jobs/62197344

/home/travis/build/supercollider/supercollider/lang/LangSource/SC_TerminalClient.cpp: In member function ‘void SC_TerminalClient::printUsage()’:
/home/travis/build/supercollider/supercollider/lang/LangSource/SC_TerminalClient.cpp:128:4: error: expected ‘)’ before ‘memGrowBuf’
/home/travis/build/supercollider/supercollider/lang/LangSource/SC_TerminalClient.cpp:132:3: warning: format ‘%s’ expects argument of type ‘char*’, but argument 4 has type ‘int’ [-Wformat]
/home/travis/build/supercollider/supercollider/lang/LangSource/SC_TerminalClient.cpp:132:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘const char*’ [-Wformat]
/home/travis/build/supercollider/supercollider/lang/LangSource/SC_TerminalClient.cpp:132:3: warning: format ‘%s’ expects a matching ‘char*’ argument [-Wformat]
make[2]: *** [lang/CMakeFiles/libsclang.dir/LangSource/SC_TerminalClient.cpp.o] Error 1
make[1]: *** [lang/CMakeFiles/libsclang.dir/all] Error 2
make: *** [all] Error 2

travis is teh awesome

crucialfelix
crucialfelix reviewed May 12, 2015
View reviewed changes
lang/LangSource/SC_TerminalClient.cpp
@@ -122,7 +124,7 @@ void SC_TerminalClient::printUsage()
" -s Call Main.stop on shutdown\n"
" -u <network-port-number> Set UDP listening port (default %d)\n"
" -i <ide-name> Specify IDE name (for enabling IDE-specific class code, default \"%s\")\n"
" -a Standalone mode\n",
" -a Standalone mode\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,

@gusano
sclang: use "v" cli switch for version
a0ddfc0 
Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
@gusano gusano force-pushed the t/sclang-print-version branch from 230a00c to a0ddfc0 Compare May 12, 2015 10:21
@gusano
Copy link
Member Author

gusano commented May 12, 2015

@crucialfelix thanks, force pushed

@gusano
Copy link
Member Author

gusano commented May 13, 2015

That one can be merged as well ;)

@bagong
Copy link
Contributor

bagong commented May 13, 2015

Haha, okle ;)

@bagong bagong closed this May 13, 2015
@bagong bagong reopened this May 13, 2015
@bagong
Copy link
Contributor

bagong commented May 13, 2015

Wah, wrong button ;)

bagong added a commit that referenced this pull request May 13, 2015
@bagong
Merge pull request #1459 from gusano/t/sclang-print-version
a86e12a 
Sclang: print version with -v
@bagong bagong merged commit a86e12a into supercollider:master May 13, 2015
@bagong
Copy link
Contributor

bagong commented May 15, 2015

The travis failure is a git problem, not a build failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.x
Development

Successfully merging this pull request may close these issues.
4 participants
@gusano @crucialfelix @bagong @eirikblekesaune