classlib: Convert note/cc nums in array case #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1426 |
|
I don't actually see the usefulness of this. The case where a float was passed in was quite common because people use NumberBox, but if you are passing in an array then why would you have floats in there ? and why would you expect them to be converted ? |
|
I don't know of a specific use-case for an array of floats. But, interfaces should behave predictably, especially if there's no significant cost / complexity in doing so. SuperCollider often allows arrays of values to be used interchangeably with single values - this follows that pattern. |
crucialfelix
added a commit
that referenced
this pull request
May 24, 2015
…i-note-responders classlib: Convert note/cc nums in array case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.