Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreqScope.sc: adapt to new fill property of scope. #1419

Merged
merged 1 commit into from
Apr 19, 2015
Merged

FreqScope.sc: adapt to new fill property of scope. #1419

merged 1 commit into from
Apr 19, 2015

Conversation

miczac
Copy link
Contributor

@miczac miczac commented Apr 12, 2015

scope now allows for a fill property which needs to be turned off for the Frequency Analyzer

@miczac
FreqScope.sc: adapt to new fill property of scope.
cc8c6fb 
scope allows for a fill property which needs to be turned off for the Frequency Analyzer
@miczac miczac mentioned this pull request Apr 12, 2015
Closed
@scztt
Copy link
Contributor

scztt commented Apr 12, 2015

👍
Btw, I don't have any strong feelings about defaulting fill to off / on. I think the scopes look better / are more visually legible with fill=true, but it's really up to everyone else. This change (fixing FreqScope) should be merged, though.

scztt added a commit that referenced this pull request Apr 19, 2015
@scztt
Merge pull request #1419 from miczac/master
656b38b 
FreqScope.sc: adapt to new fill property of scope.
@scztt scztt merged commit 656b38b into supercollider:master Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miczac @scztt