Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/quarks gui enhancements #1394

Merged
merged 14 commits into from
Apr 7, 2015
Merged

Topic/quarks gui enhancements #1394

merged 14 commits into from
Apr 7, 2015

Conversation

crucialfelix
Copy link
Member

Many fixes, improvements to usability.

Still not very pretty due to the buttons inside the TreeView

Please let's test before merging. I will test more too. Its probably fine though.

screen shot 2015-03-31 at 22 47 39

Note: button text has been changed to black now.

@crucialfelix
Quarks.checkForUpdates - fetch changes and tags for each checked out …
bc04d12 
…Quark
@crucialfelix
QuarksGui: "check for updates" with cancelable CmdPeriod support
7e7ee81
@crucialfelix
QuarksGui: make Y/N sort column invisible, turn off sorting after init
0ac136d 
if user sorts by name and then installs it will not annoy them by resorting
by "is installed" making them lose their place.
@crucialfelix
add installFolder button and dialog
c4bb7c3
@crucialfelix
install quark using runCancellable fixes supercollider#1376
cca3f31 
no cancel button yet, but cmdPeriod works and its async
@crucialfelix
retitle the primary action buttons for clarity, stretch them evenly
3bbed2b
@crucialfelix
QuarksGui: add a color scheme with semantic names
dbd4d35
@crucialfelix
remove redundant page title (window title already says Quarks)
c3e3fe3
@crucialfelix
fix(Git): fix remoteLatest, return tags sorted by date, add doc strings
d95e75a
@crucialfelix
rework QuarksDetailView
4581a35 
show versions in a table,
move action buttons down into the detail area
@crucialfelix
Copy link
Member Author

More screenshots here: http://imgur.com/a/21fFh

crucialfelix
crucialfelix reviewed Mar 31, 2015
View reviewed changes
SCClassLibrary/Common/Quarks/Git.sc
@@ -87,6 +98,7 @@ Git {
cmd = ["git"];
});
cmd = (cmd ++ args).join(" ");
// this blocks the app thread
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need another way to get the output of a command. Probably I can change it to use Pipe but that still blocks while its in getLine.

@crucialfelix
Copy link
Member Author

to test:

git checkout https://github.com/supercollider/supercollider/pull/1394

@miguel-negrao
Copy link
Member

I gave this branch a brief test, it looks very nice and everything I tested was working.

@crucialfelix
Copy link
Member Author

I found one minor issue and worked on a fix yesterday. will push it today.
should not require further testing.

thanks for trying it miguel !

On Mon, Apr 6, 2015 at 12:51 PM Miguel Negrão notifications@github.com
wrote:

I gave this branch a brief test, it looks very nice and everything I
tested was working.

—
Reply to this email directly or view it on GitHub
#1394 (comment)
.

crucialfelix added a commit that referenced this pull request Apr 7, 2015
@crucialfelix
Merge pull request #1394 from crucialfelix/topic/quarks-gui-enhancements
1d060f7 
Topic/quarks gui enhancements
@crucialfelix crucialfelix merged commit 1d060f7 into supercollider:master Apr 7, 2015
@crucialfelix crucialfelix deleted the topic/quarks-gui-enhancements branch April 7, 2015 11:36
@bagong
Copy link
Contributor

bagong commented Apr 7, 2015

A lot of love went in, I can see that. Will test tomorrow...

@crucialfelix
Copy link
Member Author

Also a lot of annoying parsing of git documentation went in there.

http://git-man-page-generator.lokaltog.net/

On Tue, Apr 7, 2015 at 1:47 PM Rainer Schütz notifications@github.com
wrote:

A lot of love went in, I can see that. Will test tomorrow...

—
Reply to this email directly or view it on GitHub
#1394 (comment)
.

@bagong
Copy link
Contributor

bagong commented Apr 8, 2015

Are you taking kind of fundamental discussion of the gu-interface? I have some suggestions, a few pretty radical, but maybe it's not the time yet? (I am keeping those back in the list below, but it's a fuzzy border, of course)
I haven't found any show-stopper bugs, but maybe you want to consider this:

  • if the help-browser is closed in SC it isn't opened by help buttons in Quarks
  • the "asking for help button doesn't bring the help window to the front" might be a general issue, but it's pretty crucial in case of the Quarks, as nothing seems to happen if you press help in a secondary window.
  • if html- and scdoc-help are provided, html help is shown (although scdoc is more likely to be up to date)
  • if you "install" a Quark the options show classes etc are displayed in the additional window although
    they are not available yet (requires recompile)
  • doing "uninstall all" (dangerous ;)) doesn't activate the recompile button
    Inconvenience:
  • the list display is confusing and the interaction between the "sort by name" and "bring installed and downloaded to top of list" adds more to this. I think it would both simplify and clarify things if the list was always ordered by name and the order installed->downloaded->available was fixed. The first column should simply go

A general thought: it might be worth thinking about having "Quarks" system become the general tool to assemble ones classes. So one might think about it replacing the preferences include/exclude dialog in the IDE preferences. A few hints in that direction are scattered over threads in the issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crucialfelix @miguel-negrao @bagong